[Libguestfs] [PATCH 6/12] hivexsh: Change some exit(1) -> exit(EXIT_FAILURE)

Richard W.M. Jones rjones at redhat.com
Thu Feb 4 12:42:18 UTC 2010


On Thu, Feb 04, 2010 at 12:04:04PM +0000, Matthew Booth wrote:
> On 03/02/10 18:33, Richard W.M. Jones wrote:
> > Subject: [PATCH 06/12] hivexsh: Change some exit(1) -> exit(EXIT_FAILURE)
> > 
> > ---
> >  hivex/hivexsh.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> ACK.
> 
> Incidentally, why? I hate magic numbers, but still use 0 and 1 for exit
> codes.

IIRC we check for it in 'make syntax-check'.

Are there platforms which exit with non-standard codes?  VMS
apparently ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list