[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/3] Converter: Fix virtio test for existing kernels



On Tue, Feb 16, 2010 at 02:46:58PM +0000, Matthew Booth wrote:
> The existing test on a pre-installed kernel wasn't dereferencing an array,
> meaning it never detected an existing kernel as virtio capable.
> ---
>  lib/Sys/VirtV2V/Converter/Linux.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/Sys/VirtV2V/Converter/Linux.pm b/lib/Sys/VirtV2V/Converter/Linux.pm
> index d5a93a7..87eeeb3 100644
> --- a/lib/Sys/VirtV2V/Converter/Linux.pm
> +++ b/lib/Sys/VirtV2V/Converter/Linux.pm
> @@ -261,7 +261,7 @@ sub _configure_kernel
>              "virtio_net" => undef
>          );
>  
> -        foreach my $module ($kernel->{modules}) {
> +        foreach my $module (@{$kernel->{modules}}) {
>              if(exists($checklist{$module})) {
>                  $checklist{$module} = 1;
>              }
> -- 

Static typing FTW.

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]