[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] Debian libguestfs packages updated



On Mon, Feb 22, 2010 at 02:41:22PM +0100, Guido Günther wrote:
> Hi,
> I finally updated the Debian libguestfs packages:
> 
> http://honk.sigxcpu.org/con/Libguestfs__Virtual_Machine_Image_Swiss_Army_Knife.html
> 
> Sine we can't run the fuse tests easily in a chroot (since we might be
> unable to load the module) I'm using the attached patch to skip the
> tests if /dev/fuse doesn't exist. This probably isn't clean enough to go
> upstream though.

Funnily enough, we [Fedora] cannot run the FUSE tests either, because
the people who run our build machines refuse to install the fuse.ko
module.  For this reason we carry the following non-upstream patch:

http://cvs.fedoraproject.org/viewvc/devel/libguestfs/libguestfs-1.0.79-no-fuse-test.patch?view=markup

I think your patch is neater, but I don't want to apply it because I'm
not happy about skipping tests magically (admittedly we do skip tests
magically elsewhere).

Probably the answer is ./configure --disable-fuse-tests.

> The other patch adjusts the test output of rhbz557655. xstrtol seems to
> be behaving differently here. I didn't investigate why yet.
[...]
> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)

That's unexpected, and needs further investigation.

I opened a bug about it to investigate this further:

https://bugzilla.redhat.com/show_bug.cgi?id=567567

> As a last point: is there a simple way to disable the appliance build
> altogether? I'd like to ship the Debian package without it so we stay
> out of the security update trouble and provide them via http.

There's not a way to disable it at the moment, but I would
accept a patch which added ./configure --disable-appliance.

Have you thought about distributing the supermin appliance?  That
should have no security update implications, and it's what we do in
Fedora, precisely for this reason, also because it's much smaller.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]