[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 9/13] hivex: Add missing le32toh conversion around field



Richard W.M. Jones wrote:
>>From 596de09265076de8fe4909f662e898159dfc3736 Mon Sep 17 00:00:00 2001
> This was missing.  It only worked because we test on a little
> endian platform.
...
> -      hive_node_h subkey = lf->keys[i].offset;
> +      hive_node_h subkey = le32toh (lf->keys[i].offset);

Is there a convenient way to build just the hivex-related bits
and test it independently of all the rest?
Since it's relatively portable, that should be feasible
to run on ppc or s390.

That looks fine.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]