[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 5/13] hivex: Move header checksum code into a function.



On Thu, Jan 28, 2010 at 06:35:29PM +0100, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > Subject: [PATCH 05/13] hivex: Move header checksum code into a function.
> >
> > This function can be reused later.
> ...
> > +static uint32_t
> > +header_checksum (hive_h *h)
> 
> This parameter can/should be "const".
> Is there some reason it's not?

Yes that is correct.  And I just pushed that change thinking it
was so simple :-(  I'll fix it with a const-correctness commit now.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]