[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] hivex: add hivex_set_value api call



On Sat, 3 Jul 2010 18:42:09 +0100
"Richard W.M. Jones" <rjones redhat com> wrote:
> On Sat, Jul 03, 2010 at 09:22:20AM -0700, Conrad Meyer wrote:
> > Not included: Perl or OCaml binding glue.
> 
> Are you intending to go further with this?  The most crucial missing
> part is the tests.  We test via Perl code, so this implies a Perl
> binding (should be very easy to add).

Ah, ok. I'll do this.

> Have you loaded up files that you've modified this way on Windows?
> Subtle mistakes (more accurately: things which the hacked-together
> Windows code is not expecting) can cause registries to be silently
> corrupted.

No, this is completely untested. I poked around a little but didn't see
C language tests -- I guess I'll try my hand at Perl bindings and write
some tests.

> I had a quick look at the code and the only mistake I could spot is:
> 
> > +    if (strcmp (valkey, val->key) == 0)
> 
> First of all use the STR* macros, secondly everything in registry
> files that is visible externally is matched case *in*sensitively.

Ah, thanks for spotting that. I'll fix this and resubmit.

Regards,
-- 
Conrad Meyer <cemeyer cs washington edu>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]