[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/3] Pull out socket connect/handshake code from guestfs__launch



On Mon, Jul 05, 2010 at 12:25:59PM -0400, Daniel P. Berrange wrote:
> The guestfs__launch code does many different things at once.
> To enable code reuse in later patches, pull out some reusable
> bits of functionality into static help methods

AFAICT this is just code motion, so that's fine.  But:

>  - guestfs__connect_tcp() wait for a connection from a
>    QEMU slirp client over a TCP socket
> 
>  - guestfs__connect_unix() connect to a UNIX domain socket
>    server running in QEMU
> 
>  - guestfs__connect_handshake() perform the initial
>    handshake with the guest daemon.

Shouldn't these functions be static?  I also think the names
are a bit unclear, perhaps:

  - connect_incoming_tcp
  - connect_outgoing_unix
  - connect_handshake

(just suggestions - maybe you can think of better ones).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]