[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] hivex: add hivex_set_value api call and perl bindings, tests



On Tue, 6 Jul 2010 08:46:21 +0100
"Richard W.M. Jones" <rjones redhat com> wrote:

> On Sat, Jul 03, 2010 at 12:03:42PM -0700, Conrad Meyer
> wrote:
> > +  "node_set_value", (RErr, [AHive; ANode "node";
> > ASetValue; AUnusedFlags]),
> 
> I think you're creating a lot of additional complexity for
> yourself here by creating a new ASetValue hash type with 3
> fields.  Instead you could add just an int32 type to the
> generator (far simpler to implement) and write this call as:
> 
> "node_set_value", (RErr, [AHive; ANode "node";
>        AString "key"; AInt32 "t"; AString "val";
> AUnusedFlags]),

This should also have a length argument, no?

> > +    "set a single (key, value) pair at a given node",
> > +    "\
> > +This call can be used to set a single (key, value) pair
> > +stored in C<node>.
> 
> Here, say:
> 
>   This call can be used to replace a single (key, value)
> pair stored in C<node>.  If the key does not already exist,
> then a new key is added.  Key matching is case insensitive.

Sure :)

-- 
Conrad Meyer <cemeyer cs washington edu>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]