[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] hivex: add hivex_set_value api call and perl bindings, tests



On Tue, Jul 06, 2010 at 09:07:19PM -0700, Conrad Meyer wrote:
> On Tue, 6 Jul 2010 08:46:21 +0100
> "Richard W.M. Jones" <rjones redhat com> wrote:
> 
> > On Sat, Jul 03, 2010 at 12:03:42PM -0700, Conrad Meyer
> > wrote:
> > > +  "node_set_value", (RErr, [AHive; ANode "node";
> > > ASetValue; AUnusedFlags]),
> > 
> > I think you're creating a lot of additional complexity for
> > yourself here by creating a new ASetValue hash type with 3
> > fields.  Instead you could add just an int32 type to the
> > generator (far simpler to implement) and write this call as:
> > 
> > "node_set_value", (RErr, [AHive; ANode "node";
> >        AString "key"; AInt32 "t"; AString "val";
> > AUnusedFlags]),
> 
> This should also have a length argument, no?

Yes.  Maybe I'm talking myself into reusing the existing
hive_set_value structure after all ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]