[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] New API: is-lv: check if a block device is a logical volume (RHBZ#619793)



On 30/07/10 16:58, Richard W.M. Jones wrote:
On Fri, Jul 30, 2010 at 04:48:27PM +0100, Matthew Booth wrote:
+  ("is_lv", (RBool "lvflag", [Device "device"]), 264, [Optional "lvm2"],
+   [InitBasicFSonLVM, IfAvailable "lvm2", TestOutputTrue (
+      [["is_lv"; "/dev/VG/LV"]]);

This obviously needs to be a real test...

+    InitBasicFSonLVM, IfAvailable "lvm2", TestOutputFalse (
+      [["is_lv"; "/dev/sda1"]])],
+   "test if device is a logical volume",
+   "\
+This command tests whether C<device>   is a logical volume, and
+returns true iff this is the case.");
+
  ]

ACK once the test is added.

Not sure I understand.  Those are both real tests (and I checked --
they do both pass).

I didn't appreciate /dev/VG/LV was real. ACK.

Matt
--
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]