[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] RHEV: Pad disk sizes up to a multiple of 1024 bytes



On Tue, Jun 01, 2010 at 12:00:28PM +0100, Matthew Booth wrote:
> Fixes RHBZ#585144
> +    # exactly, we will pad to to a 1024 byte boundary.
> +    $self->{outsize} = ceil($insize/1024) * 1024;

Does this work on a 32 bit machine?  Perl might try to promote
these to floats.

Anyway the fix looks good for 64 bit, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]