[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] daemon: Limit label lengths (RHBZ#597118).



On Wed, Jun 02, 2010 at 01:42:32PM +0100, Matthew Booth wrote:
> On 01/06/10 16:20, Richard W.M. Jones wrote:
>>> From f5f43227870f4a2bedbd92361acdc3ca371a8418 Mon Sep 17 00:00:00 2001
>> From: Richard Jones<rjones redhat com>
>> Date: Tue, 1 Jun 2010 15:50:14 +0100
>> Subject: [PATCH 1/2] daemon: Limit label lengths (RHBZ#597118).
>>
>> ---
>>   daemon/ext2.c |   21 +++++++++++++++++++++
>>   daemon/swap.c |   21 +++++++++++++++++++++
>>   2 files changed, 42 insertions(+), 0 deletions(-)
>>
>
> If we could pull those numbers directly from the kernel headers that  
> would be preferable. However, assuming that's not possible, ACK.

Unfortunately they aren't exported.

For reference, the sources are:

  http://lxr.linux.no/linux+v2.6.34/fs/ext4/ext4.h#L848
  char    s_volume_name[16];      /* volume name */

  http://lxr.linux.no/linux+v2.6.34/include/linux/swap.h#L91
  unsigned char   sws_volume[16];

(I don't think these URLs are really stable, so I won't add them to
the commit message.)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]