[Libguestfs] [PATCH] ESX: Always validate SSL certificate

Matthew Booth mbooth at redhat.com
Mon Jun 7 12:32:35 UTC 2010


Since fetching storage from ESX was split into separate HEAD and GET requests,
the SSL certificate has only been validated on the HEAD request. It should be
validated on both.
---
 lib/Sys/VirtV2V/Transfer/ESX.pm |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/Sys/VirtV2V/Transfer/ESX.pm b/lib/Sys/VirtV2V/Transfer/ESX.pm
index f638149..5d6b586 100644
--- a/lib/Sys/VirtV2V/Transfer/ESX.pm
+++ b/lib/Sys/VirtV2V/Transfer/ESX.pm
@@ -143,6 +143,8 @@ sub get_volume
         my $died = $r->header('X-Died');
         die($died) if (defined($died));
 
+        $self->verify_certificate($r) unless ($self->{_v2v_noverify});
+
         # It reports success even if we didn't receive the whole file
         die(user_message(__x("Didn't receive full volume. Received {received} ".
                              "of {total} bytes.",
-- 
1.7.0.1




More information about the Libguestfs mailing list