[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/3] Fix RHEV cleanup on unclean shutdown



On Tue, Jun 08, 2010 at 03:55:48PM +0100, Matthew Booth wrote:
> Cleanup was not happening properly if a migration to RHEV was killed
> prematurely with a Ctrl-C. Firstly, the SIGINT and SIGQUIT handlers were not
> being registered early enough in virt-v2v.pl. Secondly, if Ctrl-C killed the
> guestfs qemu process first it would deliver a SIGPIPE to v2v, which caused an
> unclean shutdown without cleanup.

Yes, looks like a correct use of signal handlers and exit (so the
atexit handler is called inside libguestfs), so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]