[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix cleanup of guest handle when installing with local files



On Wed, Jun 09, 2010 at 05:19:09PM +0100, Matthew Booth wrote:
> Change 13412f7629133b25fda32c35fdb0276e22de3445 caused Config to keep a
> reference to the guestfs handle in certain circumstances. This caused a
> regression in the cleanup code because the handle was no longer closed in
> close_guest_handle.
> 
> This change explicitly drops the reference to $config before closing the guest
> handle. It also localises $guestos, which also keeps a reference to the guestfs
> handle in an eval block.

ACK as discussed on IRC.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]