[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] New APIs: Query the relationship between LVM objects.



On Thu, Mar 18, 2010 at 03:36:14PM +0100, Jim Meyering wrote:
> > +               "/sbin/lvm", cmd,
> 
> You probably have a fine reason to do it, but seeing
> hard-coded absolute tool names like that makes me cringe.
> (yeah, I see it already appears many times in lvm.c, but still)

These are a kind of "note to self" to fix path handling in the daemon.
The path should be set to include /sbin and /usr/sbin and then we can
remove all hard-coded references like this in one go.

Thanks for the review.  I'll make the other changes that you
suggested.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]