[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/3] daemon: Fix hexdump to work on absolute symbolic links



On Thu, May 06, 2010 at 10:04:54PM +0100, Richard W.M. Jones wrote:
> +  CHROOT_IN;
> +  fd = open (path, O_RDONLY);
> +  CHROOT_OUT;
> +
> +  if (fd == -1) {
> +    perror (path);
       ^^^
This should be:

  reply_with_perror ("%s", path);

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]