[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2v] config: 'os' and 'distro' fields should be matched separately.



On 07/05/10 11:28, Richard W.M. Jones wrote:
> On Fri, May 07, 2010 at 11:05:52AM +0100, Matthew Booth wrote:
>> On 06/05/10 17:54, Richard W.M. Jones wrote:
>>> >From ca375bb29295523238e297820d4f641db01d9742 Mon Sep 17 00:00:00 2001
>>> From: Richard Jones <rjones redhat com>
>>> Date: Thu, 6 May 2010 17:51:58 +0100
>>> Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
>>>
>>> This is particularly important for Windows guests, because these
>>> only have os='windows' and distro is not set.
>>> ---
>>>  lib/Sys/VirtV2V/Config.pm |   30 ++++++++++++++++++------------
>>>  v2v/virt-v2v.conf         |   34 +++++++++++++++++-----------------
>>>  2 files changed, 35 insertions(+), 29 deletions(-)
>>
>> Could you please also update v2v/virt-v2v.conf.pod?
> 
> How about this [attached]?

Looks fine.

> You say in the documentation that matching happens in this order:
> 
>        ·   os, distro, major, minor, arch
> 
>        ·   os, distro, major, minor
> 
>        ·   os, distro, major, arch
> 
>        ·   os, distro, major
> 
>        ·   os, distro
> 
>        ·   os
> 
> but is that really true?

I belived so when I wrote it :) If it isn't it's a bug.

> Also I don't think it's a good idea to include the whole default
> configuration file in the man page.  I think you should just tell them
> where to look for it.  If you agree I will prepare an updated patch.

You're probably right. A pointer to the default is probably sufficient.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]