[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/3] daemon: Change command to abort() on resource problems.



On 06/05/10 22:03, Richard W.M. Jones wrote:
>>From fd62c985a26bfd0cac27735a47ce7fd7b068fdb4 Mon Sep 17 00:00:00 2001
> From: Richard Jones <rjones redhat com>
> Date: Thu, 6 May 2010 20:32:09 +0100
> Subject: [PATCH 1/3] daemon: Change command to abort() on resource problems.
> 
> The comment in the code describes it thus:
> 
>   /* Note: abort is used in a few places along the error paths early
>    * in this function.  This is because (a) cleaning up correctly is
>    * very complex at these places and (b) abort is used when a
>    * resource problems is indicated which would be due to much more
>    * serious issues - eg. memory or file descriptor leaks.  We
>    * wouldn't expect fork(2) or pipe(2) to fail in normal
>    * circumstances.
>    */

ACK.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]