[Libguestfs] [PATCH 2/8] GuestOS: Remove unused add_application function

Matthew Booth mbooth at redhat.com
Wed May 19 16:50:34 UTC 2010


---
 lib/Sys/VirtV2V/GuestOS.pm        |   13 -------------
 lib/Sys/VirtV2V/GuestOS/RedHat.pm |   34 ----------------------------------
 2 files changed, 0 insertions(+), 47 deletions(-)

diff --git a/lib/Sys/VirtV2V/GuestOS.pm b/lib/Sys/VirtV2V/GuestOS.pm
index e5b1704..7d3f1c7 100644
--- a/lib/Sys/VirtV2V/GuestOS.pm
+++ b/lib/Sys/VirtV2V/GuestOS.pm
@@ -271,19 +271,6 @@ The version number of the kernel to be removed.
 
 remove_kernel uninstalls a kernel from the guest.
 
-=item add_application(label)
-
-=over
-
-=item label
-
-The label of the application to be installed. See L<virt-v2v.conf(5)> for more
-details.
-
-=back
-
-add_application installs an application and its dependencies into the guest.
-
 =item remove_application(name)
 
 =over
diff --git a/lib/Sys/VirtV2V/GuestOS/RedHat.pm b/lib/Sys/VirtV2V/GuestOS/RedHat.pm
index ffa85be..a51b082 100644
--- a/lib/Sys/VirtV2V/GuestOS/RedHat.pm
+++ b/lib/Sys/VirtV2V/GuestOS/RedHat.pm
@@ -782,40 +782,6 @@ sub remove_kernel
     $self->_augeas_error($@) if ($@);
 }
 
-=item add_application(label)
-
-See BACKEND INTERFACE in L<Sys::VirtV2V::GuestOS> for details.
-
-=cut
-
-sub add_application
-{
-    my $self = shift;
-    my $label = shift;
-
-    my $desc = $self->{desc};
-    my $user_arch = $desc->{arch};
-
-    my $config = $self->{config};
-    my ($app, $deps) = $config->match_app($self->{desc}, $label, $user_arch);
-
-    my @missing;
-    if (!$self->{g}->exists($self->_transfer_path($app))) {
-        push(@missing, $app);
-    } else {
-        return if ($self->_newer_installed($app));
-    }
-
-    my @install = ($app);
-
-    # Add any dependencies which aren't already installed to the install set
-    push(@install, $self->_get_deppaths(\@missing, $user_arch, @$deps));
-
-    _die_missing(@missing) if (@missing > 0);
-
-    $self->_install_rpms(1, @install);
-}
-
 sub _get_nevra
 {
     my $self = shift;
-- 
1.6.6.1




More information about the Libguestfs mailing list