[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/4] fish: Allow suffixes on number parameters (eg. 1M)



Richard W.M. Jones wrote:
> Subject: [PATCH 1/4] fish: Allow suffixes on number parameters (eg. 1M)
>
> This small change uses the gnulib xstrtoll functionality to
> enable suffixes on integer parameters in guestfish.  For example:
>
>  truncate-size /file 1G
>
> (previously you would have had to given the full number).

Nice.  This all looks fine.

My only surprise was to see no addition of xstrtoll to the list of
modules in bootstrap, but that's fine, because it was already there.

> This also applies to the 'alloc' and 'sparse' commands (and
> indirectly to the -N option).  The specification for these commands
> has changed slightly, in that 'alloc foo 1MB' would now use SI
> units, allocating 1000000 bytes instead of a true megabyte.  All
> existing uses would use 'alloc foo 1M' which still allocates true
> megabytes.
> ---
>  fish/alloc.c                           |   34 ++-----
>  fish/fish.c                            |   24 +----
>  fish/guestfish.pod                     |  162 ++++++++++++++++++--------------
>  regressions/rhbz557655-expected.stderr |    2 -
>  regressions/rhbz557655.sh              |    6 +-
>  src/generator.ml                       |    5 +-
>  6 files changed, 113 insertions(+), 120 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]