[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix Windows conversion when ControlSet001 isn't the CurrentControlSet



On Tue, Oct 19, 2010 at 10:38:55AM +0100, Matthew Booth wrote:
[...]

Patch looks good, ACK.  My only worry is what happens if the following
code fails (missing key, unexpected type etc), but I guess that won't
happen for a real registry, and if it does we'll get an exception
which will propagate out into a useful error message.

> +    # Get the 'Current' ControlSet. This is normally 001, but not always.
> +    my $select = $h->node_get_child($h->root(), 'Select');
> +    my $current_cs = $h->node_get_value($select, 'Current');
> +    $current_cs = sprintf("ControlSet%03i", $h->value_dword($current_cs));

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]