[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] daemon: Fix /dev/mapper paths from mounts and mountpoints (RHBZ#646432).



On Wed, Oct 27, 2010 at 02:53:07PM +0100, Richard W.M. Jones wrote:
> +  for (i = 0; ret[i] != NULL; i += 2) {

This line in the patch is wrong.  It skips over pairs of strings,
which is good for 'mountpoints' but bad for 'mounts'.  The line should
be:

+  for (i = 0; ret[i] != NULL; i += mp ? 2 : 1) {

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]