[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix build of po-docs during initial build

On 29/10/10 12:03, Richard W.M. Jones wrote:
On Fri, Oct 29, 2010 at 11:06:23AM +0100, Matthew Booth wrote:

Building po-docs currently fails because po-docs/ja/Makefile.am requires files
which are generated by po-docs/Makefile.am, which the latter does not create by

This patch doesn't fix the dependencies properly, but fixes the problem by
ensuring that po-docs/Makefile.am will build all LINGUA deps by default.

NAK, it's wrong to update-po on an ordinary build.  This would mean
that the po files are constantly being rebuilt.  They should only be
rebuilt at 'make dist' time.

'Only' doesn't quite work here. The default make target currently builds the translated man pages by default. These man pages depend on the output of po4a, which also updates the .po files. Potential solutions I can think of are:

1. Run update-po (po4a) automatically when .pod or .pl files are missing
2. Check all the .pod and .pl files into git
3. Don't generate translated man pages by default.

Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]