[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] compilation nit



I've just tried to build the latest from git, and it failed like this:

    events.c: In function 'guestfs___call_callbacks_message':
    events.c:128:7: error: implicit declaration of function 'strlen' [-Werror=implicit-function-declaration]
    events.c:128:39: error: incompatible implicit declaration of built-in function 'strlen' [-Werror]
    events.c:131:38: error: incompatible implicit declaration of built-in function 'strlen' [-Werror]
    events.c:139:35: error: incompatible implicit declaration of built-in function 'strlen' [-Werror]
    cc1: all warnings being treated as errors

    make[3]: *** [libguestfs_la-events.lo] Error 1
    make[3]: *** Waiting for unfinished jobs....
    make[3]: Leaving directory `/h/j/w/co/libguestfs/src'
    make[2]: *** [all] Error 2
    make[2]: Leaving directory `/h/j/w/co/libguestfs/src'
    make[1]: *** [all-recursive] Error 1
    make[1]: Leaving directory `/h/j/w/co/libguestfs'
    make: *** [all] Error 2

Applying this change got past it:

>From 8edaf5949f404b4fd94886ce5772d55f54ef3024 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Wed, 13 Apr 2011 11:10:08 +0200
Subject: [PATCH libguestfs] avoid warning about implicit declaration of
 strlen

* src/events.c: Include <string.h>, for use of strlen.
---
 src/events.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/events.c b/src/events.c
index 159862a..3894349 100644
--- a/src/events.c
+++ b/src/events.c
@@ -26,6 +26,7 @@
 #include <inttypes.h>
 #include <unistd.h>
 #include <assert.h>
+#include <string.h>

 #include "ignore-value.h"

--
1.7.5.rc1.228.g86d60b


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]