[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 6/7] Fix logging of error messages in augeas_error



On Tue, Apr 26, 2011 at 05:03:51PM +0100, Matthew Booth wrote:
> ---
>  lib/Sys/VirtConvert/Util.pm |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Sys/VirtConvert/Util.pm b/lib/Sys/VirtConvert/Util.pm
> index 94211a5..b74d750 100644
> --- a/lib/Sys/VirtConvert/Util.pm
> +++ b/lib/Sys/VirtConvert/Util.pm
> @@ -121,8 +121,8 @@ sub augeas_error
>  
>      chomp($msg);
>  
> -    v2vdie $msg if length($msg) > 0;
> -    v2vdie $err;
> +    v2vdie($msg) if length($msg) > 0;
> +    v2vdie($err);
>  }

ACK.

Bit surprised the without-parens version doesn't work though ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]