[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 5/6] out-of-tree build: fix tests in images directory



On Wed, Aug 17, 2011 at 12:42:01AM +0200, Hilko Bengen wrote:
> diff --git a/run b/run
> index 2945315..08422e7 100755
> --- a/run
> +++ b/run
> @@ -29,9 +29,7 @@
>  
>  #----------------------------------------------------------------------
>  
> -# Find this script.
> -run=$(readlink -f "$0")
> -b=$(dirname "$run")
> +b=${TOP_BUILDDIR}
>  
>  # Set TMPDIR so the appliance doesn't conflict with globally
>  # installed libguestfs.

This part is definitely not right because the ./run script is intended
to be used by any user (and I use it all the time), not just from
'make check'.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]