[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2] NEW API: add blkid command to print the attributes of the device



On Sun, Dec 04, 2011 at 08:29:09PM +0800, Wanlong Gao wrote:
> On 12/04/2011 08:09 PM, Richard W.M. Jones wrote:
> 
> > On Sun, Dec 04, 2011 at 07:45:07PM +0800, Wanlong Gao wrote:
> >> So, for the future of *libguestfs*, can we add something to separate
> >> these disto?  For example we can remove the features like *-p* from
> >> RHEL5 but add it to RHEL6 or some fedora distos?
> > 
> > I agree.  To do this we need to detect at runtime if the -p and/or -i
> > options are supported, and add them as appropriate.  See for example:
> > 
> > http://git.annexia.org/?p=libguestfs.git;a=blob;f=daemon/parted.c;h=0d229484276d677e9ccc27e89bda5004d09c4631;hb=HEAD#l278
> > http://git.annexia.org/?p=libguestfs.git;a=blob;f=daemon/swap.c;h=51dbbe483f6748ae0508a622d5998d6b38d6ff87;hb=HEAD#l36
> > 
> 
> 
> Thank a lot Rich.
> I'll work out a patch and test it tomorrow.

Thanks ... BTW I have reverted both of my patches, so the
code is now back to your original.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]