[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 8/8 v2 DISCUSSION ONLY] fish: Add guestfish --live, guestmount --live options.



On Fri, Jan 28, 2011 at 07:39:09PM +0000, Richard W.M. Jones wrote:
> 
> -- 
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> virt-top is 'top' for virtual machines.  Tiny program with many
> powerful monitoring features, net stats, disk stats, logging, etc.
> http://et.redhat.com/~rjones/virt-top

> >From 4891a885aa7058faba901c059f08ddfbc5d43159 Mon Sep 17 00:00:00 2001
> From: Richard W.M. Jones <rjones redhat com>
> Date: Fri, 28 Jan 2011 19:25:02 +0000
> Subject: [PATCH 8/8] fish: Add guestfish --live, guestmount --live options.
> 
> The other programs have the variable, but the flag is not enabled
> either because it doesn't make sense or because the implications are
> not well understood.
> ---
>  cat/virt-cat.c             |    2 ++
>  cat/virt-filesystems.c     |    2 ++
>  cat/virt-ls.c              |    2 ++
>  df/main.c                  |    2 ++

I would have thought it was ok to support --live in
these 4, since they're readonly apps in any case.

>  fish/fish.c                |    5 +++++
>  fish/guestfish.pod         |    5 +++++
>  fish/inspect.c             |    6 ++++++
>  fish/options.h             |    1 +
>  fish/virt.c                |    4 ++++
>  fuse/guestmount.c          |    5 +++++
>  fuse/guestmount.pod        |    5 +++++
>  inspector/virt-inspector.c |    2 ++
>  rescue/virt-rescue.c       |    2 ++

--live probably isn't useful for virt-rescue since if
you need to rescue a machine it likely isn't running
correctly & thus not have a guestfsd available.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]