[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Fix subclassing of LibVirtXMLSource



On Mon, Jan 17, 2011 at 04:34:08PM +0000, Matthew Booth wrote:
> LibVirtXMLSource was subclassing an invalid class, and consequently didn't have
> copy_storage defined.
> 
> Fixes RHBZ#670175
> ---
>  lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm
> index e62d996..ffb9309 100644
> --- a/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm
> +++ b/lib/Sys/VirtV2V/Connection/LibVirtXMLSource.pm
> @@ -30,7 +30,7 @@ use Sys::VirtV2V::Util qw(user_message parse_libvirt_volinfo);
>  
>  use Locale::TextDomain 'virt-v2v';
>  
> - Sys::VirtV2V::Connection::Source::LibVirtXMLSource::ISA =
> + Sys::VirtV2V::Connection::LibVirtXMLSource::ISA =
>      qw(Sys::VirtV2V::Connection::Source);
>  
>  =pod

ACK.

Strong typing FTW ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]