[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH hivex 02/14] maint: remove unnecessary test-before-free



From: Jim Meyering <meyering redhat com>

* lib/hivex.c (hivex_node_set_value): Remove unnecessary
test-before-free.
---
 lib/hivex.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lib/hivex.c b/lib/hivex.c
index d042f4f..a72fa77 100644
--- a/lib/hivex.c
+++ b/lib/hivex.c
@@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node,

  leave_partial:
   for (int i = 0; i < alloc_ct; i += 2) {
-    if (values[i / 2].value != NULL)
-      free (values[i / 2].value);
+    free (values[i / 2].value);
     if (i + 1 < alloc_ct && values[i / 2].key != NULL)
       free (values[i / 2].key);
   }
-- 
1.7.6.rc2.302.gc2115


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]