[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/3] hivex: check for presence of OCaml native compiler



On Thu, May 12, 2011 at 12:04:19AM +0200, bengen hilluzination de wrote:
> From: Hilko Bengen <bengen hilluzination de>
> 
> Only compile bytecode otherwise, avoiding ocamlfind's helpful error
> message "ocamlfind: Not supported in your configuration: ocamlopt"
> 
> (Successfully tested on Debian/unstable on alpha)

The problem with this patch is that OCaml users won't get the native
version.  This is vital on platforms that do have the native compiler.

The fix here must be to detect if the native version is available and
compile it conditionally.  ocaml-autoconf macros are already doing the
detection, see:

https://forge.ocamlcore.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=ocaml-autoconf/ocaml-autoconf.git;a=blob;f=ocaml.m4.pod;h=25734584264c96e65bbc38fdce833939d0891f1b;hb=HEAD#l41

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]