[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2] Add tune2fs command.



On Fri, Nov 11, 2011 at 09:34:25AM +0000, Matthew Booth wrote:
> On 10/11/11 17:52, Richard W.M. Jones wrote:
> >The changes since the previous patch:
> >
> >  - safe ADD_ARG macro for adding arguments to a fixed size stack array
> >
> >  - support for testing functions that return RHashtable, ie. tune2fs-l.
> >
> >  - add tests that set (tune2fs) and get (tune2fs-l) various parameters.
> >
> >  - only one 'intervalbetweenchecks' parameter (in seconds)
> >
> >Rich.
> >
> 
> ACK to the series.

Thanks.  I pushed it, making a small change to the ADD_ARG macro so
that you can also use it like this:

  size_t MAX_ARGS = <some computed number>;
  const char *argv[MAX_ARGS];
  size_t i = 0;

  ADD_ARG (argv, i, ...);

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=edd502543adbdc2fa5dda0c015ea7c390bb39f64#patch2

There are more places in the daemon code which should be updated to
use the new macro, eg:

http://git.annexia.org/?p=libguestfs.git;a=blob;f=daemon/debug.c;h=bb91c9ef9eb6bd0359cb3076f707ef854bcb438b;hb=edd502543adbdc2fa5dda0c015ea7c390bb39f64#l354

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]