[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] Create an MD variant of the dummy Fedora image



General comment:

Can you use git send-email to send the patches?  I think I had
problems applying those patches before, but now I'm finding it
problematic to apply patches that are attachments.

> +# Make a (dummy) Fedora image using md devices
> +fedora-md1.img fedora-md2.img: guest-aux/make-fedora-img.pl \

I believe this will run the Perl script twice on updates.  You need to
use a stamp file, eg:

  fedora-md1.img fedora-md2.img: stamp-fedora-md

  stamp-fedora-md: guest-aux/make-fedora-img.pl  [etc]
    [rules]

The tests pass for me, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]