[Libguestfs] [PATCH 1/2] Create an MD variant of the dummy Fedora image

[Matthew Booth]

On 22/11/11 16:01, Richard W.M. Jones wrote:
> General comment:
>
> Can you use git send-email to send the patches?  I think I had
> problems applying those patches before, but now I'm finding it
> problematic to apply patches that are attachments.

I do use git send-email, and if you remember I only changed the defaults 
because you were having problems with them ;) I currently have this in 
.git/config in my local libguestfs repo:

[format]
   attach

I'll remove it again...

>> +# Make a (dummy) Fedora image using md devices
>> +fedora-md1.img fedora-md2.img: guest-aux/make-fedora-img.pl \
>
> I believe this will run the Perl script twice on updates.  You need to
> use a stamp file, eg:
>
>    fedora-md1.img fedora-md2.img: stamp-fedora-md
>
>    stamp-fedora-md: guest-aux/make-fedora-img.pl  [etc]
>      [rules]

I don't think it will. Makefile will process the 2 images files in 
order. The creation of fedora-md1.img will also create fedora-md2.img. 
When processing fedora-md2.img, the timestamp check will prevent it 
being run again.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490