[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] New API: mdadm-stop for stopping MD devices.



On Wed, Nov 23, 2011 at 03:02:19PM +0000, Matthew Booth wrote:
> On 23/11/11 14:43, Wanlong Gao wrote:
> >This API is used to stop a md device.
> >When we want to move a device to another md array, we should
> >stop the md device which contained this device first.
> 
> I'm not convinced we should extend the md api in libguestfs to
> active manipulation. I wasn't convinced that mdadm-create was
> worthwhile either, but it made a test case ever so slightly tidier.
> To me, MD devices are the domain of physical machines. We need to be
> able to *read* them (for P2V apart from anything else), but I think
> manipulation is opening an unnecessary can of worms.

But is there any penalty to carrying this?

I was inclined to accept this patch, although I will tidy
up the documentation.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]