[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [hivex][PATCH 2/8] generator: Add new return type to ABI: RLenValue



On Thu, Oct 20, 2011 at 12:37:54PM +0100, Richard W.M. Jones wrote:
> of the tests could have picked up this type of bug.  I think the tests
> (all of them) need to be changed to be more thorough.

And while you're doing that, is there a way to avoid the
hard-coded '297680'?

I suggest two possibilities: create another test hive (derived from
'large') which will be specific to this test and we will never change
in future.  Since this won't change, we can go ahead and use
hard-coded offsets.

Or properly iterate through the hive using the standard APIs, to pick
out the nodes we want to test.

Second is probably better, but obviously more work.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]