[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/7] generator: Add new return types to ABI: RLenNode and RLenValue



On Thu, Sep 01, 2011 at 06:17:31PM -0700, Alex Nelson wrote:
> RLenNode and RLenValue are similar to RLenType, though with one less
> argument.  This required adding one processing function for OCaml and
> Python.

Seems like this patch is partly unnecessary?

At least, nothing in any later patch appears to return RLenNode.  The
two functions that previously used this now return RSize (which is a
good thing).

As for RLenValue, the new function value_data_cell_offset returns
this, so this part of the patch should be included.  I think you
should rework this patch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]