[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 6/7] hivexml: Report attributes in values instead of text.



On Thu, Sep 01, 2011 at 06:17:43PM -0700, Alex Nelson wrote:
> Reporting value data in attributes has two advantages:
> * The output of hivexml breaks Python expat processing if binary data
> makes it out.  This was observed in Software hives.
> * Not having child text makes room for child elements.

ACK, pushed 4 of the patches now.

BTW please run 'make check' and test all the bindings.  I had to fix
the OCaml bindings, and a mistake in errno handling in hivex_value_key
was revealed by 'make check'.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]