[Libguestfs] [PATCH 0/5] Patch to build hivex lib on Windows

[Gillen Daniel]

On 09/07/2011 01:45 PM, Richard W.M. Jones wrote:
> On Tue, Sep 06, 2011 at 11:31:11PM +0200, Gillen Daniel wrote:
>> This patch series adds mmap / munmap replacement functions to be
>> able to build hivex library on Windows (mingw)
>
> I've applied an equivalent patch:
> http://git.annexia.org/?p=hivex.git;a=commitdiff;h=085707078097f6def993b20a794001d6c06f1492
>
> I tested it using the Fedora Windows cross-compiler.  Please check it
> still works in your environment.
>
> Some comments:
>
> Lots of small patches are easier to review.  However each patch still
> needs to be an atomic, consistent commit, which wasn't the case here.
> 'git format-patch' or 'git send-email' makes it simpler both for you
> to send, and for me to apply, patches.
>
> We had some discussion on IRC about how to reduce the impact on the
> main code further.  There were two proposals: either to implement a
> hashtable in the Windows mmap code to map<something>  to hive handles.
> Or to do what we did (which is a bit of a hack):
>    #define mmap(...) mmap (h, ...)
> This isn't the best solution, but it'll do til we think of something
> better.
>
> Files not listed in *_SOURCES so make dist would have failed.
>
> Rich.
>

Works fine for me using MinGW 3.18 (gcc 4.5.2) on Win XP. Many thx for 
adding.

-- 
Unix _IS_ user friendly - it's just
selective about who its friends are!