[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH V4] virt-sysprep:add logging feature



On 04/11/2012 08:33 PM, Richard W.M. Jones wrote:

> On Wed, Apr 11, 2012 at 08:05:29PM +0800, Wanlong Gao wrote:
>> I thinks users often want to know what is virt-sysprep doing on his
>> guest, if silence, I don't know if the process is running or already
>> hang up. So, I also think that showing simple logging for users should
>> be made default.
>>
>> Above all, I think keep silently when running for a bit long time is
>> not a good idea, do you think so?
> 
> Well maybe, maybe not.  Certainly the logging by default should be
> informative, and it should be possible to turn it off (like
> 'virt-resize --quiet').
> 
> How about we log just the high level operations as they are performed,
> as in the attached patch?


Yeah, agreed.

Reviewed-by: Wanlong Gao <gaowanlong cn fujitsu com>

Thanks,
Wanlong Gao

> 
> Rich.
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]