[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] collect list of called external commands



On Thu, Aug 30, 2012 at 05:53:06PM +0200, Olaf Hering wrote:
> On Thu, Aug 30, Olaf Hering wrote:
> 
> > -extern int e2prog (char *name); /* Massive hack for RHEL 5. */
> > +extern int e2prog (const char *name); /* Massive hack for RHEL 5. */
> 
> > +++ b/daemon/ext2.c
> 
> > -e2prog (char *name)
> > +e2prog (const char *name)
> >  {
> >    char *p = strstr (name, "e2");
> >    if (!p) return 0;
> >    p++;
> > +  return 0;
> 
> 
> The whole patch was a mechanical change.  e2prog certainly needs a
> better change, if any.  Is RHEL still supposed to be handled that way,
> rewriting the command name?

Unfortunately yes, though only for RHEL 5.

But since we're maintaining a separate branch for RHEL 5 now[1], we
might just push this peculiarity entirely into that branch.

Rich.

[1] https://github.com/libguestfs/libguestfs/tree/oldlinux

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]