[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Add support for getting and setting GPT partition type GUIDs

On 14/12/12 15:12, Richard W.M. Jones wrote:
On Fri, Dec 14, 2012 at 01:54:24PM +0000, Matthew Booth wrote:
diff --git a/generator/types.ml b/generator/types.ml
index cff3c6d..a2e3307 100644
--- a/generator/types.ml
+++ b/generator/types.ml
@@ -332,6 +332,11 @@ and test_init =
       * Note: for testing filesystem operations, it is quicker to use
       * InitScratchFS
+  | InitGPT
+    (* Identical to InitPartition, except that the partition table is GPT
+     * instead of MBR.
+     *)
    | InitBasicFS

      (* /dev/sda:

This comment is in the wrong place isn't it?

Yup. There were also a couple of other issues:

* I left some debug output in
* The documented behaviour on MBR partition is wrong: it returns an 'equivalent' GUID, not an error.
* It doesn't always output errors on stderr

Fixes coming up.


Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]