[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] daemon: Remove redundant fork in commandrvf



On Fri, Dec 14, 2012 at 03:20:52PM +0000, Richard W.M. Jones wrote:
> On Thu, Dec 13, 2012 at 03:22:39PM +0000, Matthew Booth wrote:
> > Currently the code is doing a redundant fork when passed the
> > COMMAND_FLAG_CHROOT_COPY_FILE_TO_STDIN flag. The additional sub-process does a
> > chroot() which has no effect because all file handles are already open at that
> > point, then simply copies its input to its output.
> > 
> > This change simply replaces the above with a dup2 of the passed file handle to
> > STDIN of the command process.
> 
> NACK.  This removes the chroot call, so I don't see how it can
> be right.

OK, I don't see how the chroot is used either.  I'll push this patch,
but I'm running *all* the tests on it first ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]