[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH 0/3] Fix guestfish edit command.



This is a further, more comprehensive fix for
https://bugzilla.redhat.com/show_bug.cgi?id=788641

The guestfish 'edit' command (aka 'emacs', 'vi') suffered from the
same problems as virt-edit and more.  It could have failed and left a
partially overwritten file, and it didn't preserve permissions etc
from the original file.

These three patches fix all this.  The first is a code cleanup.  The
second causes 'edit' to write to a temporary file which is atomically
moved over the original.  The third copies permissions etc from the
original to the new file.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]