[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [hivex] [PATCH 8/8] hivexml: Add byte run reporting functions



Thanks.

I have pushed patches 1-7.  I made a small change to the description
of the function in patch 3.

However this patch (8) cannot go in because it provokes many gcc
warnings.  Try configuring hivex with:

  ./configure --enable-gcc-warnings

and recompile hivexml (possibly you'll only see warnings on a 64 bit
machine).

One example of several:

On Wed, Dec 07, 2011 at 06:38:15PM -0800, Alex Nelson wrote:
> +  snprintf (buf, 1+BYTE_RUN_BUF_LEN, "%d", node);

You can't do this sort of thing because node is a size_t, not an int.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]