[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/3] launch: don't add a drive twice



On 01/09/2012 06:28 PM, Richard W.M. Jones wrote:

> On Mon, Jan 09, 2012 at 03:22:43PM +0800, Wanlong Gao wrote:
>> 1. Change the g->path to restore a absolute path instead of the mixed.
>> 2. Check that if the adding drive is duplicated with the added drive.
> 
> We were trying to work out if there is a valid case where you
> might add the same drive twice.  I can't think of one at the
> moment ...


But, adding the same drive twice or more will cause many problems
in qemu, So, why not just add only once, it'll be better and be
consistent with the real drives.

If not, at least, IMHO, store a absolute path is better then the origin
filename we passed to the add_drive_* functions.

Agree?

Thanks
-Wanlong Gao

> 
> Rich.
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]