[Libguestfs] [PATCH] fish: Do not emit error message if history file cannot be open for writing.
Richard W.M. Jones
rjones at redhat.com
Wed Jan 11 10:24:40 UTC 2012
On Tue, Jan 10, 2012 at 11:35:11PM +0100, Hilko Bengen wrote:
> The error message generated by perror() is not particularly useful to
> the user. Many other command line programs that can keep history
> around cope silently if they can't create or write to their history
> file.
> ---
> fish/fish.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/fish/fish.c b/fish/fish.c
> index b782b7c..bf976ea 100644
> --- a/fish/fish.c
> +++ b/fish/fish.c
> @@ -1433,10 +1433,8 @@ cleanup_readline (void)
>
> if (histfile[0] != '\0') {
> fd = open (histfile, O_WRONLY|O_CREAT, 0644);
> - if (fd == -1) {
> - perror (histfile);
> + if (fd == -1)
> return;
> - }
> close (fd);
>
> #ifdef HAVE_APPEND_HISTORY
ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
More information about the Libguestfs
mailing list