[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/3] NEW API: add a new api e2fsck



On Fri, Jan 13, 2012 at 10:55:57PM +0800, Wanlong Gao wrote:
>  int
> +do_e2fsck (const char *device,
> +           int correct,
> +           int forceall)

Actually, does this compile?  I think you want to optargs_bitmask.
See 'do_mkfs_opts' for an example.

'./configure --enable-gcc-warnings' will catch errors like this.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]