[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] c: NFC Remove redundant parentheses



On Tue, Jan 17, 2012 at 01:48:47PM +0000, Matthew Booth wrote:
> ---
>  generator/generator_c.ml |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/generator/generator_c.ml b/generator/generator_c.ml
> index 4324ec0..9cfb2b7 100644
> --- a/generator/generator_c.ml
> +++ b/generator/generator_c.ml
> @@ -1187,7 +1187,7 @@ trace_send_line (guestfs_h *g)
>              let n = name_of_optargt argt in
>              let uc_shortname = String.uppercase shortname in
>              let uc_n = String.uppercase n in
> -            pr "  if ((optargs->bitmask & GUESTFS_%s_%s_BITMASK))\n"
> +            pr "  if (optargs->bitmask & GUESTFS_%s_%s_BITMASK)\n"
>                uc_shortname uc_n;
>              (match argt with
>               | OBool n

NACK.  I believe this avoids a gcc warning where it's complaining
that you've "mistakenly" written if (a & b) instead of if (a && b).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]